Play 3.0 upgrade #1559
Merged
Play 3.0 upgrade #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfurey
force-pushed
the
play-3.0-upgrade
branch
from
1408c45
to
58f9ae3
Compare
|
Cursory checks on CODE look fine. |
Hopefully this isn't needed - it is a Dev mode only setting
To version which supports Play 3.0
davidfurey
force-pushed
the
play-3.0-upgrade
branch
from
45bc4fd
to
9a8120e
Compare
jonathonherbert
approved these changes
May 8, 2024
Caused by play-json groupId changing from com.typesafe.play to org.playframework
This is required because v1.0.0-M15 depends on software.amazon.awssdk:dynamodb:2.15.78 which depends on jackson-databind:2.10.5.1, which is binary incompatible with jackson-databind:2.16.2 which is depended on by com.amazonaws:aws-java-sdk-core:1.12.470. Scanamo v1.0.0 uses software.amazon.awssdk:dynamodb:2.23.4 See FasterXML/jackson-databind#2897
``` [warn] /Users/david_furey/code/facia-tool/app/controllers/UserDataController.scala:23:69: Reference to uninitialized value Trail [warn] implicit val UserData: DynamoFormat[UserData] = deriveDynamoFormat[UserData] [warn] ^ [warn] /Users/david_furey/code/facia-tool/app/controllers/UserDataController.scala:24:63: Reference to uninitialized value JsValue [warn] implicit val Trail: DynamoFormat[Trail] = deriveDynamoFormat[Trail] [warn] ^ [warn] two warnings found ```
davidfurey
force-pushed
the
play-3.0-upgrade
branch
from
9a8120e
to
7c3e961
Compare
Good spot. I've update the description and rewritten the commit |
|
Seen on PROD (merged by @davidfurey 5 minutes and 58 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Main change is upgrading to Play 3.0
Library upgrades to versions supporting Play 3.0
Library upgrades to align transitive dependencies
Other changes